Skip to content
Snippets Groups Projects

Default `authorized_keys_enabled` setting to true

Merged Michael Kozono requested to merge fix-authorized-keys-enabled-default-2738 into master

What does this MR do?

Sets the column default for the Application Setting authorized_keys_enabled to true and rebuilds the authorized_keys file.

Why was this MR needed?

https://gitlab.com/gitlab-org/gitlab-ee/issues/2738

EE installations that were upgraded to 9.3 stopped writing to the authorized_keys file by default. The setting authorized_keys_enabled was nil. So additions and deletions of SSH keys had no effect on SSH operations.

When I added the setting, I mistakenly thought settings were merged with ApplicationSetting.defaults. However, if there exists an ApplicationSetting record, defaults is never used.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Fixes #2738 (closed)

Edited by Michael Kozono

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Michael Kozono added 5 commits

    added 5 commits

    Compare with previous version

  • Would it make sense to skip rebuilding keys, and ship the fix for a default value first?

  • Douwe Maan mentioned in merge request !2256 (merged)

    mentioned in merge request !2256 (merged)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading