Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 34,895
    • Issues 34,895
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,229
    • Merge Requests 1,229
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !2240

Merged
Opened Jun 24, 2017 by Michael Kozono@mkozono🔶Maintainer0 of 9 tasks completed0/9 tasks

Default `authorized_keys_enabled` setting to true

  • Overview 91
  • Commits 18
  • Pipelines 20
  • Changes 17

What does this MR do?

Sets the column default for the Application Setting authorized_keys_enabled to true and rebuilds the authorized_keys file.

Why was this MR needed?

https://gitlab.com/gitlab-org/gitlab-ee/issues/2738

EE installations that were upgraded to 9.3 stopped writing to the authorized_keys file by default. The setting authorized_keys_enabled was nil. So additions and deletions of SSH keys had no effect on SSH operations.

When I added the setting, I mistakenly thought settings were merged with ApplicationSetting.defaults. However, if there exists an ApplicationSetting record, defaults is never used.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if it does - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

Fixes #2738 (closed)

Edited Jun 28, 2017 by Michael Kozono
Assignee
Assign to
Reviewer
Request review from
9.3
Milestone
9.3 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab!2240
Source branch: fix-authorized-keys-enabled-default-2738

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.