Test plan for "Preview comments for batch comments in merge requests"
Introduction
This test plan is for https://gitlab.com/gitlab-org/gitlab-ee/issues/4327. The feature adds a preview stage to submission of a batch of comments (added in https://gitlab.com/gitlab-org/gitlab-ee/issues/1984 and covered in test plan https://gitlab.com/gitlab-org/gitlab-ee/issues/7275)
Scope
- The review feature is only available in merge requests, when creating a discussion from a code line, or replying to a discussion (from a code line or from the “Discussion” tab) — it is not available when adding a comment/discussion in the “Discussion” tab.
- Out of scope: sending a single email for a batch of comments (see: https://gitlab.com/gitlab-org/gitlab-ee/issues/4326)
ACC Matrix
| Intuitive | Responsive | Reliable | |
|---|---|---|---|
| MRs | 2 | 1 | 1 |
For more information about the ACC Matrix see the Google Testing Blog article about the 10 minute test plan and this wiki page from an open-source tool that implements the ACC model.
Capabilities
MRs are
- Intuitive
- Clicking on a comment in the preview navigates to the comment in the MR.
- Clicking on a non-code comment in the preview navigates to the comment in the MR's Discussion tab.
- It's clearly indicated when a comment changes the resolved status of a discussion.
- Reliable
- The preview shows only comments included in the review.
- Responsive
- Performance is good even on large MRs with many discussions and comments.
Test Plan
Automated end-to-end tests
Scenario 1: Preview with included and excluded comments
- Add code and non-code comments to an MR that aren't part of a review.
- Start a review and add code and non-code comments. Have one resolve a discussion and another unresolve a discussion.
- Preview and check that all review comments are included and that all non-review comments are not included.
- Check that resolution status changes are reported.
- Click on a code comment in the preview and check that it navigates to the correct comment
- Repeat for a non-code comment.
- Submit and check that comments appear and that resolution status changes occur.
Edited by 🤖 GitLab Bot 🤖