Skip to content

Drop skip-if-larger flag for pngquant

Sarah German requested to merge pngquant-drop-flag into 16.0

What does this MR do and why?

The 16.0 pipeline fails with an error from pngquant, which is used to compress images: https://gitlab.com/gitlab-org/gitlab-docs/-/jobs/7410082817

We tried adjusting the script (!4928 (merged)) to not return an error if this happens, but this did not work. I can't reproduce the issue locally but it has persisted across multiple pipeline runs.

Let's just drop the --skip-if-larger flag from Pngquant. This should prevent the script from ever exiting with code 98 (see https://manpages.debian.org/testing/pngquant/pngquant.1.en.html).

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Configure a local GitLab Docs environment: https://gitlab.com/gitlab-org/gitlab-docs/-/blob/main/doc/setup.md.
  2. Run make compile
  3. Compress images with ./scripts/compress_images.sh public

Expected behavior: no errors, images get compressed

Merge request acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sarah German

Merge request reports