Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab Docs GitLab Docs
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 169
    • Issues 169
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab DocsGitLab Docs
  • Merge requests
  • !362

Global nav

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Marcia Ramos requested to merge global-nav into master Nov 13, 2018
  • Overview 128
  • Commits 80
  • Pipelines 39
  • Changes 9
  • For gitlab-com&21 (closed)
  • Closes https://gitlab.com/gitlab-com/gitlab-docs/issues/169
  • Clean-up after https://gitlab.com/gitlab-com/gitlab-docs/merge_requests/356 - see all history there!

REVIEW APP: http://global-nav.178.62.207.141.xip.io/ce/README.html

MVC:

  • Create the global nav
  • Make it work on mobile (hidden on mobile ATM)
  • BE review (just double check)
  • FE review

FOR FE review:

  • When we scroll down the nav, when it finishes scrolling, the page starts scrolling the content. Fix this to simply when the nav stops scrolling, just stop right there.
  • Try to fix buggy ToC toggle (note that it's displayed only on mobile):
    • the first click doesn't collapse it
    • on the next clicks, there's a brief (weird) pause when the div is collapsing

PREVIEWING IT LOCALLY:

    1. Open a terminal in CE:
    • git pull
    • git checkout docs-add-global-nav
    1. Open a terminal in gitlab-docs:
    • git pull
    • git checkout global-nav
    • bundle install (to update the gems)
    • bundle exec nanoc compile
    • bundle exec nanoc live
    1. Preview at http://localhost:3000/ce/README.html

BEFORE MERGING:

  • Transfer <%= render '/global_nav.*' %> to default doc and delete default-copy
  • Revert .gitlab-ci.yml to branch master
Edited Nov 26, 2018 by Marcia Ramos
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: global-nav