Global nav
- For gitlab-com&21 (closed)
- Closes https://gitlab.com/gitlab-com/gitlab-docs/issues/169
- Clean-up after https://gitlab.com/gitlab-com/gitlab-docs/merge_requests/356 - see all history there!
REVIEW APP: http://global-nav.178.62.207.141.xip.io/ce/README.html
MVC:
-
Create the global nav -
Make it work on mobile (hidden on mobile ATM) -
BE review (just double check) -
FE review
FOR FE review:
-
When we scroll down the nav, when it finishes scrolling, the page starts scrolling the content. Fix this to simply when the nav stops scrolling, just stop right there. -
Try to fix buggy ToC toggle (note that it's displayed only on mobile): - the first click doesn't collapse it
- on the next clicks, there's a brief (weird) pause when the div is collapsing
PREVIEWING IT LOCALLY:
-
- Open a terminal in CE:
git pull
git checkout docs-add-global-nav
-
- Open a terminal in gitlab-docs:
git pull
git checkout global-nav
-
bundle install
(to update the gems) bundle exec nanoc compile
bundle exec nanoc live
-
- Preview at
http://localhost:3000/ce/README.html
- Preview at
BEFORE MERGING:
-
Transfer <%= render '/global_nav.*' %>
to default doc and delete default-copy -
Revert .gitlab-ci.yml
to branchmaster
Edited by Marcia Ramos
Merge request reports
Activity
- Automatically resolved by Marcia Ramos
mentioned in merge request !356 (closed)
assigned to @ashmckenzie
added 1 commit
- f20c5826 - Nav: Allow devops_stages sections order to be set
@marcia I've updated
lib/helpers/nav.rb
to support the ability to sort a section's categories. I've added some comments as documentation to show the options that existassigned to @marcia
Please register or sign in to reply