Skip to content
Snippets Groups Projects

Global nav

Merged Marcia Ramos requested to merge global-nav into master

REVIEW APP: http://global-nav.178.62.207.141.xip.io/ce/README.html

MVC:

  • Create the global nav
  • Make it work on mobile (hidden on mobile ATM)
  • BE review (just double check)
  • FE review

FOR FE review:

  • When we scroll down the nav, when it finishes scrolling, the page starts scrolling the content. Fix this to simply when the nav stops scrolling, just stop right there.
  • Try to fix buggy ToC toggle (note that it's displayed only on mobile):
    • the first click doesn't collapse it
    • on the next clicks, there's a brief (weird) pause when the div is collapsing

PREVIEWING IT LOCALLY:

    1. Open a terminal in CE:
    • git pull
    • git checkout docs-add-global-nav
    1. Open a terminal in gitlab-docs:
    • git pull
    • git checkout global-nav
    • bundle install (to update the gems)
    • bundle exec nanoc compile
    • bundle exec nanoc live
    1. Preview at http://localhost:3000/ce/README.html

BEFORE MERGING:

  • Transfer <%= render '/global_nav.*' %> to default doc and delete default-copy
  • Revert .gitlab-ci.yml to branch master
Edited by Marcia Ramos

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marcia Ramos added 3 commits

    added 3 commits

    • ddaf1168 - Treat user docs a little differently
    • 27c8b3bc - Add custom category name for CI/CD docs
    • f120a2d9 - Change branch for reorg nav

    Compare with previous version

  • Marcia Ramos resolved all discussions

    resolved all discussions

  • Marcia Ramos added 1 commit

    added 1 commit

    • cb55e613 - Remove blogging helper (for now)

    Compare with previous version

  • Marcia Ramos changed the description

    changed the description

  • Marcia Ramos mentioned in merge request !356 (closed)

    mentioned in merge request !356 (closed)

  • Marcia Ramos changed the description

    changed the description

  • Marcia Ramos changed the description

    changed the description

  • Ash McKenzie added 1 commit

    added 1 commit

    • f20c5826 - Nav: Allow devops_stages sections order to be set

    Compare with previous version

  • Ash McKenzie added 1 commit

    added 1 commit

    • ea01b161 - Nav: Allow section categories to be sorted

    Compare with previous version

  • Ash McKenzie added 1 commit

    added 1 commit

    • 731c8f87 - Nav: Allow section categories to be sorted

    Compare with previous version

  • @marcia I've updated lib/helpers/nav.rb to support the ability to sort a section's categories. I've added some comments as documentation to show the options that exist :smile:

  • assigned to @marcia

  • Marcia Ramos added 3 commits

    added 3 commits

    • 3a9fabec - Add GitLab Design System to development nav
    • 0ac199c9 - Customize nav categories order
    • 0663ad43 - improve styles

    Compare with previous version

  • Marcia Ramos added 4 commits

    added 4 commits

    Compare with previous version

  • Marcia Ramos changed the description

    changed the description

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading