Since the frontend code now gets bundled with Rollup, it's a good idea to also think about the size of our bundles.
At this stage, not a lot of the frontend code gets bundled, but the amount of bundled code will increase as we build more features. We should be able to reduce our bundle size by introducing a minification plugin such as rollup-plugin-uglify.
Benefits
Reduced bundle sizes mean fewer bytes being downloaded to the client, which leads to faster page loads and less bandwidth usage.
Designs
Child items
...
Show closed items
Linked items
0
Link issues together to show that they're related or that one is blocking others.
Learn more.
@axil is minification of our JS assets currently enabled on docs.gitlab.com?
I just did some spot checks and it doesn't look like our JS is being minified:
This file for example should exclude whitespaces, line breaks, and comments:
I will double check today for you but I am pretty sure this can't be closed yet as there is no minification process for the JS that I saw, I will see what I can do
I wanted to add that the new version of Minify has a much improved minifier for JavaScript files now, which should help reducing file sizes even further.
This one has not been done yet, its a bit down the list of priorities after the deeper side menu navigation and the home page re-design which are taking up the most time currently, though this is on my TODO list
@jerasmus - Thanks for confirming the behavior and passing this along.
@oregand - Thanks for the update. Is there another issue or MR related to this, so that we can see where it is in the priority list? Just trying to get a better understanding of where things are in the different lists of things to do. And thank you for all of the things you do with making the docs site better.
Thanks for the update. Is there another issue or MR related to this, so that we can see where it is in the priority list? Just trying to get a better understanding of where things are in the different lists of things to do. And thank you for all of the things you do with making the docs site better.
I am always happy to help where I can! I don't think we currently track a priority list outside of the one I keep in my head
Currently, the list is:
Homepage redesign
Left navigation nested levels
Gitlab UI/SVG
After that I would circle back to @eread for whats the most important thing to tackle Should we consider keeping an Epic?
@oregand - I'm not sure I want to create an epic, because epics should (like every other issue) have a discrete beginning and ending and "make continual improvements to the docs site" doesn't strike me as having an ending date.
Perhaps a label of some sort to allow remaining work to be put onto an issue board would be helpful? It'd be worth bringing @susantacker into this discussion, as I think she's been coordinating the direction and efforts for docs site development.
No worries at all! I would be happy to open for a label to define the current priority items, perhaps frontend-weight1 - frontend-weight5 could be used?