Skip to content

Add gitlab-styles, RSpec gems

Ash McKenzie requested to merge 285-consider-using-gitlab-default-shared-styles-for-rubocop-1 into master

What does this Merge Request do?

This foundational MR (part of a number of MRs being introduced to make it easier for !1199 (closed)) to be merged re-introduces a Gemfile back into the GDK. The justification for this is as follows:

  • The local development and GDK CI jobs use RSpec to run specs but we currently have no way to ensure we're running the same version
  • We will soon be running RuboCop utilising the https://gitlab.com/gitlab-org/gitlab-styles gem and so we'll need a way to ensure we're also running a consistent version

#649 (closed) removed the Gemfile for the following reasons:

  1. The gdk command cannot be run in directories other then the GDK_ROOT
  2. We risk Gemfile environment poisoning

In my local testing, I have not been able to replicate item 1. or come up with a scenario that shows 2. in action.

@toon and @jacobvosmaer-gitlab may we please have your thoughts?

Related #285 (closed)

Merge Request checklist

  • Tests added for new functionality. If not, please raise Issue to follow-up.
  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Documentation added/updated, if needed.
  • gdk doctor test added, if needed.

Merge request reports