WIP: Use gitlab-styles with rubocop (!1199) · Merge requests · GitLab.org / GitLab Development Kit · GitLab

Ash McKenzie requested to merge 285-consider-using-gitlab-default-shared-styles-for-rubocop into master Apr 23, 2020

What does this Merge Request do?

This MR does the following:

Adds a new test:rubocop CI job
Adds a Gemfile so gitlab-styles and rspec can be bundled
Fixes all 'autocorrectable' RuboCop offences
Disables non-trivial RuboCop offences (for now)
Disables some cops - 2320fa09 (Rails and RSpec/ContextWording)

Merge Request checklist

[-] Tests added for new functionality. If not, please raise Issue to follow-up.
This change is backward compatible. If not, please include steps to communicate to our users.
[-] Documentation added/updated, if needed.
[-] gdk doctor test added, if needed.

Closes #285 (closed)