Call for volunteer reviewers: Mass button migration MR round 2
Help us review a Mass Button Migration MR!
As part of our ongoing component migration push, the Foundations team was able to create a second mass button migration MR which migrates ~120 buttons in one MR! While we believe this is low risk, we would still like to get eyes on the MR from Product Designers across the product. This MR came as a bit of surprise and for this reason, we are calling for volunteers to help us review it!
Details
- When: The week of July 4th-7th
- Where: In this merge request
- Who: Any designers who are able to volunteer a little bit of their time
- Why: We want to ensure there are no major bugs prior to merging the mass migration MR
-
What we need from you:
- If you are able to volunteer some time, please help pull down the MR into a local environment. This can be using GDK, gitpod, or a review app.
- Review the list of files in the ux review tracker and add your name next to the file you will review. Once you've completed the review, please check the checkmark to indicate the review is complete.
Your help on July 4th-7th will allow us to quickly migrate low risk components quickly and efficiently. We are aiming to merge this MR before Pajamas migration day on the 14th, so we have a clear understanding of what needs to be migrated manually on that day
Review tips
If you need to review many pages in GDK, to save ~10–20s per page you can precompile all the pages by turning off incremental webpack compilation.
What should I do if I find a bug?
If you find a bug when reviewing the MR, first check to ensure it does not currently exist on master
. If you confirm the MR is introducing a new bug or visual regression, please create a threaded comment on the MR, so we can look into fixing it!
Where can I get help?
If you have any questions, don't hesitate to reach out in the #g_manage_foundations channel or post a question to the merge request.
What do I do when I am done?
If you find no bugs, please mark the file(s) you completed review as checked in the ux review tracker.