Skip to content
Snippets Groups Projects

Make cycle_analytics_events_spec.rb side-effect free

What does this MR do?

I was not able to reproduce the transient failure locally but I believe it happens when run in combination with other specs.

Basically querying for MergeRequest.order(...).first is a recipe for unpredictable specs since a merge request could be created for another project in the meantime, and we'd assert against a merge request IID that doesn't belong to the current project. I'm not 100% how this could happen since specs should always start with a clean state, but :shrug:!

Closes #26622 (closed) /cc @jameslopez

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading