Project 'gitlab-org/gitlab-ce' was moved to 'gitlab-org/gitlab-foss'. Please update any links and bookmarks that may still have the old path.
Fix constrainers for relative url
1 unresolved thread
1 unresolved thread
What does this MR do?
Sub relative url from request path in routing constrainer
Why was this MR needed?
To prevent 404 when visit group page when GitLab setup configured for relative url
What are the relevant issue numbers?
Merge request reports
Activity
Mentioned in issue #23101 (closed)
@smcgivern please review
Added 1 commit:
- ccd81a87 - Add changelog item for groups 404 on relative url
LGTM, thanks @dzaporozhets!
17 17 it { expect(subject.matches?(request '/g/gitlab')).to be_falsey } 18 18 it { expect(subject.matches?(request '/.gitlab')).to be_falsey } 19 19 end 20 21 context 'relative url' do 22 before do 23 allow(Gitlab::Application.config).to receive(:relative_url_root) { '/gitlab' } 24 end 25 26 it { expect(subject.matches?(request '/gitlab/gitlab')).to be_truthy } In !6992 (merged) @vsizov proposed to combine multiple
it
blocks to speedup the specs. Shall we do it also here?I think it's needed for cases when it takes too long to setup the proper environment for actual expectation. For this particular case it's not, I think.
Edited by Valery Sizov
Mentioned in commit f2644adf
Mentioned in issue #23728 (closed)
Mentioned in issue #23656 (closed)
Reassigned to @smcgivern
Mentioned in commit 6d84f057
Please register or sign in to reply