Skip to content
Snippets Groups Projects

Updates sidebar to use new dropdowns for issues and merge requests

Merged Jacob Schatz requested to merge functional-sidebar into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • 7fb5a016 - Adds milestone API JS call
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • 6d962fb8 - Sidebar milestone updatable via JSON
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • 62b7539b - Ajax call to milestones via new dropdowns
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • a2899e4e - Make label search work with JSON data
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • b3edacdf - Add milestone sidebar update via JSON
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • 289a2e78 - Add labels as proper POST arrays using new dropdown
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • a596c0b5 - Fix up commit message
  • Jacob Schatz Added 193 commits:

    Added 193 commits:

    • a596c0b5...ca3fc229 - 184 commits from branch master
    • 073e95c7 - Updates sidebar milestone to use new dropdowns
    • 18da2034 - Adds milestone API JS call
    • 98b33e1b - Sidebar milestone updatable via JSON
    • e6cf695a - Ajax call to milestones via new dropdowns
    • feeff70c - Make label search work with JSON data
    • 215e2afd - Add milestone sidebar update via JSON
    • f4e8c5e7 - Add labels as proper POST arrays using new dropdown
    • bed8d1ad - Fix up commit message
    • 06075053 - Removes bugs with selection.
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • 32385b7a - Fix bugs with select dropdown and multiselection
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • 00bebfc0 - Make remove multi and remove single work.
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • 9576b9a5 - Remove api calls from api.js.coffee.
  • Jacob Schatz Added 86 commits:

    Added 86 commits:

    • 9576b9a5...5fd88cdd - 73 commits from branch master
    • 2a548d08 - Updates sidebar milestone to use new dropdowns
    • e1afea39 - Adds milestone API JS call
    • 3faeff85 - Sidebar milestone updatable via JSON
    • 8cd0f8e9 - Ajax call to milestones via new dropdowns
    • da76890f - Make label search work with JSON data
    • 4fedb3df - Add milestone sidebar update via JSON
    • 0e51d6a1 - Add labels as proper POST arrays using new dropdown
    • 4341c3ba - Fix up commit message
    • aba38642 - Removes bugs with selection.
    • f30bcf0f - Fix bugs with select dropdown and multiselection
    • 417e1e1c - Make remove multi and remove single work.
    • b974e7f9 - Remove api calls from api.js.coffee.
    • 14613c69 - Adding dropdown for users
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • 0d908762 - Adds new dropdown ajax to user selection
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • 2bdb1f0a - New dropdowns work on merge requests too!
  • mentioned in issue #12935 (closed)

  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • aec18c8d - Add multi select stay open functionality
  • Jacob Schatz Added 95 commits:

    Added 95 commits:

    • aec18c8d...9f72d3ed - 79 commits from branch master
    • 2c9df4f7 - Updates sidebar milestone to use new dropdowns
    • a896dc89 - Adds milestone API JS call
    • e015c2e5 - Sidebar milestone updatable via JSON
    • 2107504f - Ajax call to milestones via new dropdowns
    • 299b4d29 - Make label search work with JSON data
    • 9473be83 - Add milestone sidebar update via JSON
    • 09331945 - Add labels as proper POST arrays using new dropdown
    • 4e4d558d - Fix up commit message
    • 563d471d - Removes bugs with selection.
    • a283ce40 - Fix bugs with select dropdown and multiselection
    • 58589146 - Make remove multi and remove single work.
    • 4ca8ef72 - Remove api calls from api.js.coffee.
    • 0942141e - Adding dropdown for users
    • f619082c - Adds new dropdown ajax to user selection
    • 1eb14612 - New dropdowns work on merge requests too!
    • 6b5a6d4d - Add multi select stay open functionality
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • d26c074b - Rename header for dropdowns
  • Jacob Schatz Title changed from [WIP]Updates sidebar milestone to use new dropdowns to Updates sidebar to use new dropdowns for issues and merge requests

    Title changed from [WIP]Updates sidebar milestone to use new dropdowns to Updates sidebar to use new dropdowns for issues and merge requests

  • Jacob Schatz Added ~149423 label

    Added ~149423 label

  • I'm going to fix failing specs

  • Reassigned to @alfredo1

  • Alfredo Sumaran Added 4 commits:

    Added 4 commits:

    • 6ca52d39 - Add missing #
    • 9f53637d - Remove unnecessary sentence
    • f3b09b94 - Fix endpoint
    • a999a5f9 - Fix specs
  • Reassigned to @jschatz1

  • Jacob Schatz Added 136 commits:

    Added 136 commits:

    • a999a5f9...5203a984 - 115 commits from branch master
    • 90cede5f - Updates sidebar milestone to use new dropdowns
    • 208182af - Adds milestone API JS call
    • 7a70e530 - Sidebar milestone updatable via JSON
    • 8b2de8c8 - Ajax call to milestones via new dropdowns
    • 41b2f88c - Make label search work with JSON data
    • caa35bc1 - Add milestone sidebar update via JSON
    • 3c1b8f91 - Add labels as proper POST arrays using new dropdown
    • ed74954b - Fix up commit message
    • b86c0ca1 - Removes bugs with selection.
    • 159d5b51 - Fix bugs with select dropdown and multiselection
    • ed0536f3 - Make remove multi and remove single work.
    • 51583621 - Remove api calls from api.js.coffee.
    • 30ab028f - Adding dropdown for users
    • 0a022677 - Adds new dropdown ajax to user selection
    • 53ccacc2 - New dropdowns work on merge requests too!
    • cb7ac599 - Add multi select stay open functionality
    • ce611da2 - Rename header for dropdowns
    • 4c024b02 - Add missing #
    • 7c9d58b9 - Remove unnecessary sentence
    • 8ad5ea0d - Fix endpoint
    • 07974db5 - Fix specs
  • Reassigned to @alfredo1

  • Reassigned to @jschatz1

  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • ca2559f9 - Fix broken functionality in sidebar after merge.
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • d8e46c1f - Fix subscription button by hooking it back up.
  • Jacob Schatz Added 38 commits:

    Added 38 commits:

    • d8e46c1f...4f0302f0 - 13 commits from branch master
    • dd5474b9 - Updates sidebar milestone to use new dropdowns
    • 8fa84221 - Adds milestone API JS call
    • 49ef3d2b - Sidebar milestone updatable via JSON
    • 4b7a4375 - Ajax call to milestones via new dropdowns
    • 03af12d3 - Make label search work with JSON data
    • fc311cd4 - Add milestone sidebar update via JSON
    • 9b52e8dd - Add labels as proper POST arrays using new dropdown
    • 9edfd637 - Fix up commit message
    • a6849802 - Removes bugs with selection.
    • 5926794e - Fix bugs with select dropdown and multiselection
    • e0fe55fa - Make remove multi and remove single work.
    • 90107621 - Remove api calls from api.js.coffee.
    • d6ceb1d2 - Adding dropdown for users
    • ef6651fc - Adds new dropdown ajax to user selection
    • 5d25115a - New dropdowns work on merge requests too!
    • 7fb6fe7f - Add multi select stay open functionality
    • ac6b017f - Rename header for dropdowns
    • 4e46145f - Add missing #
    • d6b13627 - Remove unnecessary sentence
    • e702732c - Fix endpoint
    • 1948bcaa - Fix specs
    • 8e9c7f4f - Fix broken functionality in sidebar after merge.
    • 40352259 - Fix subscription button by hooking it back up.
    • 8b7a456f - Remove console log
    • 706a9a8d - Add js-extras so show any and show no for milestones show up.
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • 995e42ec - Assign current user when no user is assigned link
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • 7da16385 - Add Assign to me button and unassigned.
  • Phil Hughes Added 1 commit:

    Added 1 commit:

    • a6c338c7 - Fixed some colours in sidebar
  • @jschatz1 pushed some CSS changes to fix some colors

  • Phil Hughes Added 1 commit:

    Added 1 commit:

    • f64b7640 - Fixed JS error that was failing the builds
  • Phil Hughes Added 127 commits:

    Added 127 commits:

    • f64b7640...ffc3acd4 - 98 commits from branch master
    • 246ec997 - Updates sidebar milestone to use new dropdowns
    • 25f0b225 - Adds milestone API JS call
    • ede34958 - Sidebar milestone updatable via JSON
    • e7f198db - Ajax call to milestones via new dropdowns
    • 43b9c3c5 - Make label search work with JSON data
    • 2dd0f7f8 - Add milestone sidebar update via JSON
    • e17e56a5 - Add labels as proper POST arrays using new dropdown
    • 4d50db88 - Fix up commit message
    • bf87104b - Removes bugs with selection.
    • d377334c - Fix bugs with select dropdown and multiselection
    • 213c2de3 - Make remove multi and remove single work.
    • 58b289fa - Remove api calls from api.js.coffee.
    • 396dcadd - Adding dropdown for users
    • 6b48a1aa - Adds new dropdown ajax to user selection
    • 76edecea - New dropdowns work on merge requests too!
    • 08e4d1cc - Add multi select stay open functionality
    • 0d8126f7 - Rename header for dropdowns
    • f7379107 - Add missing #
    • ca880bb1 - Remove unnecessary sentence
    • c8005037 - Fix endpoint
    • 0baf0ccc - Fix specs
    • 40e7d88e - Fix broken functionality in sidebar after merge.
    • 53daa975 - Fix subscription button by hooking it back up.
    • c44d8bbc - Remove console log
    • 02aa9dd7 - Add js-extras so show any and show no for milestones show up.
    • 68bdd4aa - Assign current user when no user is assigned link
    • 4f6eb559 - Add Assign to me button and unassigned.
    • 0cc5ebee - Fixed some colours in sidebar
    • ef50fe35 - Fixed JS error that was failing the builds
  • mentioned in issue #14461 (closed)

  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • e337b614 - Fix features until tests pass.
  • Jacob Schatz Added 116 commits:

    Added 116 commits:

    • e337b614...4896d49a - 86 commits from branch master
    • daeb0a06 - Updates sidebar milestone to use new dropdowns
    • 9d2e69de - Adds milestone API JS call
    • dc04c39c - Sidebar milestone updatable via JSON
    • 83f8d0a2 - Ajax call to milestones via new dropdowns
    • 437d6861 - Make label search work with JSON data
    • 5fa1e224 - Add milestone sidebar update via JSON
    • fa07a411 - Add labels as proper POST arrays using new dropdown
    • d643a501 - Fix up commit message
    • c2506b11 - Removes bugs with selection.
    • 2aa43dbf - Fix bugs with select dropdown and multiselection
    • 673cc175 - Make remove multi and remove single work.
    • 6a1e2941 - Remove api calls from api.js.coffee.
    • b2a0d18e - Adding dropdown for users
    • 7b501a30 - Adds new dropdown ajax to user selection
    • 3fa4b64c - New dropdowns work on merge requests too!
    • c283b20a - Add multi select stay open functionality
    • 2b4a98eb - Rename header for dropdowns
    • e84a0a88 - Add missing #
    • 0f0cdd71 - Remove unnecessary sentence
    • e7fdb224 - Fix endpoint
    • 8edbe09c - Fix specs
    • d27f9425 - Fix broken functionality in sidebar after merge.
    • a74dea42 - Fix subscription button by hooking it back up.
    • 2a4b6182 - Remove console log
    • 042c1bc0 - Add js-extras so show any and show no for milestones show up.
    • 9f405a49 - Assign current user when no user is assigned link
    • f839eb04 - Add Assign to me button and unassigned.
    • f55b85c9 - Fixed some colours in sidebar
    • 636f6749 - Fixed JS error that was failing the builds
    • bcc5d39e - Fix features until tests pass.
  • Jacob Schatz Added 38 commits:

    Added 38 commits:

    • bcc5d39e...fb1a7553 - 8 commits from branch master
    • e3908eaf - Updates sidebar milestone to use new dropdowns
    • eea17580 - Adds milestone API JS call
    • 19388740 - Sidebar milestone updatable via JSON
    • c31faaf6 - Ajax call to milestones via new dropdowns
    • a930e9a8 - Make label search work with JSON data
    • a8da21b0 - Add milestone sidebar update via JSON
    • 2a142a23 - Add labels as proper POST arrays using new dropdown
    • 5338e407 - Fix up commit message
    • 7b1e935f - Removes bugs with selection.
    • c82c4f11 - Fix bugs with select dropdown and multiselection
    • 81ef9bd4 - Make remove multi and remove single work.
    • f3ec126a - Remove api calls from api.js.coffee.
    • cb1ce0b8 - Adding dropdown for users
    • f09acb08 - Adds new dropdown ajax to user selection
    • 9104d2b1 - New dropdowns work on merge requests too!
    • ac6a90c1 - Add multi select stay open functionality
    • 9a4bd5a9 - Rename header for dropdowns
    • 9a2da648 - Add missing #
    • 53ae0a6f - Remove unnecessary sentence
    • dcf5de24 - Fix endpoint
    • eacedbb5 - Fix specs
    • 3daebf83 - Fix broken functionality in sidebar after merge.
    • 5643cb74 - Fix subscription button by hooking it back up.
    • 00b63c71 - Remove console log
    • 15560452 - Add js-extras so show any and show no for milestones show up.
    • b8f2f2e7 - Assign current user when no user is assigned link
    • 8e7f3cdb - Add Assign to me button and unassigned.
    • 4150f87f - Fixed some colours in sidebar
    • 1367b153 - Fixed JS error that was failing the builds
    • feded28a - Fix features until tests pass.
  • Jacob Schatz Removed ~149423 label

    Removed ~149423 label

  • Jacob Schatz Added 38 commits:

    Added 38 commits:

    • feded28a...57dd206f - 8 commits from branch master
    • fd28ce2f - Updates sidebar milestone to use new dropdowns
    • 6065c8bd - Adds milestone API JS call
    • 14b58387 - Sidebar milestone updatable via JSON
    • cd7eaa73 - Ajax call to milestones via new dropdowns
    • e03072b6 - Make label search work with JSON data
    • 73c0bfa2 - Add milestone sidebar update via JSON
    • 22e28eb8 - Add labels as proper POST arrays using new dropdown
    • 1d9923b6 - Fix up commit message
    • 71f197b9 - Removes bugs with selection.
    • 3f4fa703 - Fix bugs with select dropdown and multiselection
    • c9b94822 - Make remove multi and remove single work.
    • e3674e64 - Remove api calls from api.js.coffee.
    • ea7a9f02 - Adding dropdown for users
    • 3c66a755 - Adds new dropdown ajax to user selection
    • 93c33549 - New dropdowns work on merge requests too!
    • ee8b30b2 - Add multi select stay open functionality
    • 9006a95e - Rename header for dropdowns
    • ad17d994 - Add missing #
    • 2f7dc9df - Remove unnecessary sentence
    • 515ef9de - Fix endpoint
    • 1e3eb1ce - Fix specs
    • cc4d26cb - Fix broken functionality in sidebar after merge.
    • da50cea3 - Fix subscription button by hooking it back up.
    • d1dc10c4 - Remove console log
    • b971aff7 - Add js-extras so show any and show no for milestones show up.
    • 8d584f79 - Assign current user when no user is assigned link
    • f90aac06 - Add Assign to me button and unassigned.
    • a90af797 - Fixed some colours in sidebar
    • c8e1d7ab - Fixed JS error that was failing the builds
    • 3440efd7 - Fix features until tests pass.
  • Jacob Schatz Added 1 commit:

    Added 1 commit:

    • 44dc6957 - Add back in currentUser
  • Author Contributor

    @dzaporozhets This is the MR for swapping out the dropdowns in the sidebar with the new dropdowns.

    • Replaces the form functionality in the sidebar with regular ajax calls that return JSON.
    • The labels selector can select multiple labels at one time.
    • Adds tiny little pulse animation to label selection.
    • Clicking off of form removes the dropdown (a current issue with dropdowns).

    After this MR frontend won't be making MR's larger than 200 changes. So this is the last one.

    I've been getting conflicts a lot so if you get see conflicts, review first and I'll fix conflicts after. Otherwise we might never get this one in. If you don't mind. :wink:

  • @jschatz1 awesome. I will review and test it.

  • @jschatz1 when come from other page via turbolink -> assignee dropdown does not work

  • Author Contributor

    @dzaporozhets Really? Ok I'll check it out. I just noticed that the JSON is missing the gravatar image so I need to fix that too.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading