Label Issue

Hi Gitlab team, Please can you fix the label button? IF I have some labels and then when I try to add new label, and click the [x] to old label -- it does not automatically remove the old label. Another thing, if I can successfully remove the old label and I click again the edit label -- seems like it's not working. Video here: http://screencast.com/t/mo2v7zQ9

Hoping for your better improvement :)

Best, Rouli

Thanks @rouli. I had the same issue.

cc @jschatz1 There's a good video explaining this one!

Added ~12980 label

@JobV @DouweM This is a much larger issue because when you make a change to the labels it submits the ajax request. Solutions would be to:

1. Disable the input when ajax request is happening.
2. Redo the sidebar ajax request to not reload the whole sidebar.
3. Instead of waiting for a response from ajax to reload the sidebar, just reload it immediately.

@jschatz1 I think the labels input should work properly, being that you can just add and remove labels to your liking without strange reloads in between.

I'm all for optimistic js (3).

The theme of 8.6 is "optimistic JS"

@jschatz1 Is this a duplicate of another issue, or should we schedule it for 8.6? There's a number of other label JS issues in 8.6.

@DouweM This isn't a dup, and it is a real issue. It's a big one, because it's the way our sidebar works atm, so it's more of a current feature.

Milestone changed to 8.6

Reassigned to @jschatz1

@JobV @skyruler What exactly do you think should happen that is currently not happening? I agree that it needs to change but what needs to happen?

@JobV @skyruler Actually I think that the new dropdowns solve all the problems.

@jschatz1 what the timeline on that? This release?

Going for it today! I'll see what I can do.

Awesome, thanks!

@jschatz1 yeah totally, new dropdowns should cover this issue

Will be fixed by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3175

mentioned in merge request !3175 (merged)

Milestone changed to 8.7

Status changed to closed by commit 55df9a70

mentioned in commit 55df9a70

Hello team,

Thanks for fixing this issue. I will be closing this report :)

Thanks much, Rouli

reopened

closed