Fix display of promote to group label

What does this MR do?

Fix display of promote to group label

Since label presenter is used in label index view, label class check doesn't work as expected because the class is now LabelPresenter.

Also label.subject doesn't work as expected now because Label's model subject method is shadowed by Gitlab's presenter's method which uses subject for referencing the original object.

Instead we use a presenter's method for both checks now.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62200

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation created/updated or follow-up review issue created
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Performance and testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

changed milestone to %11.11

added regression regression:11.1 labels

marked the checklist item Changelog entry as completed

	1 Error
	58dc21e7: The commit subject may not be longer than 72 characters

	1 Warning
	52764ec5: This commit’s subject line is acceptable, but please try to reduce it to 50 characters.

	1 Message
	Consider setting merge_request to 28637 in changelogs/unreleased/jp-label-fix.yml. See the documentation.

Commit message standards

One or more commit messages do not meet our Git commit message standards. For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.

Here is an example of a good commit message:

Reject ruby interpolation in externalized strings

When using ruby interpolation in externalized strings, they can't be
detected. Which means they will never be presented to be translated.

To mix variables into translations we need to use `sprintf`
instead.

Instead of:

    _("Hello #{subject}")

Use:

    _("Hello %{subject}") % { subject: 'world' }

This is an example of a bad commit message:

updated README.md

This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
backend	Reuben Pereira (@rpereira2)	Jen-Shin Lin (@godfat)
frontend	Jacques Erasmus (@jerasmus)	Fatih Acet (@fatihacet)

Generated by Danger

@vshushlin could you please review?

assigned to @vshushlin

@wlsf82 per https://gitlab.com/gitlab-org/quality/team-tasks/issues/128#note_170783578 could you please review feature specs?

assigned to @wlsf82

added Plan [DEPRECATED] typebug labels

@jprovaznik I think we also need to change https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/helpers/labels_helper.rb#L203 to fix the tooltip on the subscribe button.

And I think https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/helpers/labels_helper.rb#L8 would cause a bug too.

Though we can do those in a separate issue / MR

added 1 commit

• a75337fa - Fix display of promote to group label

Compare with previous version

resolved all discussions

mentioned in issue #62217 (closed)

added 1 commit

• f9a55f93 - Fix display of promote to group label

Compare with previous version

unassigned @vshushlin

Thanks @vshushlin, @godfat could you please merge?

assigned to @godfat

LGTM.