Skip to content

Fix display of promote to group label

Jan Provaznik requested to merge jp-label-fix into master

What does this MR do?

Fix display of promote to group label

Since label presenter is used in label index view, label class check doesn't work as expected because the class is now LabelPresenter.

Also label.subject doesn't work as expected now because Label's model subject method is shadowed by Gitlab's presenter's method which uses subject for referencing the original object.

Instead we use a presenter's method for both checks now.


Does this MR meet the acceptance criteria?


Performance and testing


If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jan Provaznik

Merge request reports