Skip to content

Revert "Merge branch 'auto_devops_kubernetes_active' into 'master'"

Thong Kuah requested to merge revert-1cccfca1 into master

What does this MR do?

Reverts https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22929 as regression affects performance and dast job from appearing in CE

Note: we could fix by adding environment:name to performance and dast job but let's give ourself time to test this out properly. Also what environment:name ? It's implicitly review/$CI_ENVIRONMENT_SLUG by virtue of all three jobs running on except:refs: master.

Note2: Even if we fixed kubernetes: active for multiple clusters to know which environment, it will still break in that case for performance and dast as we have not defined environment: name.

Note3: dependencies is worth considering but in my tests, when there's no cluster, performance job is still present even though review job is not there.

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ee/issues/8846, https://gitlab.com/gitlab-org/gitlab-ee/issues/8311

Does this MR meet the acceptance criteria?

Edited by Thong Kuah

Merge request reports