Fix gitaly-proto version for gitlab-ce v10.7.1

What does this MR do?

Updates the gitaly-proto version for gitlab-ce v10.7.1 from v0.94.0 to v0.96.0

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

The GetSnapshot merge request originally updated the proto to v0.96.0, but just before merge, this was superceded by a commit to master that updated it to v0.97.0 - so no update hunk was picked to the 10.7 EE stable branch.

This MR fixes spec and production failures that will occur due to a dependency on missing constants and methods in the gitaly-proto gem.

It does not need to be merged to master, so I've set it to merge directly to the 10-7-stable-patch-1 branch.

changed title from Resolve "Linked issues" to Fix gitaly-proto version for gitlab-ce v10.7.1

changed the description

changed milestone to %10.7

assigned to @filipa

@filipa this and the associated EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5439 will be required to fix some NoMethodError and undefined constant errors relating to the snapshot functionality we added. Both GetSnapshot (used in CE) and CreateRepositoryFromSnapshot (used in EE) rely on a minimum gitaly-proto version of v0.96.0

gitaly-proto changes are backwards compatible, so this won't introduce any other failures.

@nick.thomas the pipeline is failing, should it be?

assigned to @rspeicher

@filipa oops, I see a transitive dependency also needs to be updated. I'll sort it out

added 1 commit

• 2b290ce9 - GetSnapshot RPC requires gitaly-proto v0.96

Compare with previous version

mentioned in merge request !18512 (merged)

@nick.thomas Could you please rebase this to bring in Stan's MySQL image fix from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18512 that I added to the prep MR branch.

assigned to @nick.thomas

added 2 commits

• badada04 - 1 commit from branch 10-7-stable-patch-1
• 26ea4397 - GetSnapshot RPC requires gitaly-proto v0.96

Compare with previous version

resolved all discussions

Done, just waiting for the EE version to be equally acceptable before assigning back.

mentioned in merge request !18500 (merged)

assigned to @filipa

@filipa this is ready to be merged into 10-7-stable-patch-1. The remaining failures are due to other unfixed failures on that branch; this change solves all the ones with @DouweM by their name.

@nick.thomas is the EE counterpart also ready to be merged? https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5439

mentioned in issue gitlab-org/release/tasks#174 (closed)

gitlab-org/release/tasks#174 (comment 69818074) Will merge this one now

approved this merge request

mentioned in commit 5cecb2ba

merged