Fixes the diff changes buttons from toggling when scrolling (!13894) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Project 'gitlab-org/gitlab-ce' was moved to 'gitlab-org/gitlab-foss'. Please update any links and bookmarks that may still have the old path.

Merged Phil Hughes requested to merge changes-bar-sticky-fix into master 7 years ago

What does this MR do?

Fixes the diff changes bar buttons from hiding/showing when scrolling in FireFox.

Also fixes a bug where being scrolled at the bottom would make the buttons be hidden at the start until scrolling.

What are the relevant issue numbers?

Closes #36698 (closed)

Activity

Phil Hughes assigned to @filipa 7 years ago

assigned to @filipa
Filipa Lacerda approved this merge request 7 years ago

approved this merge request
Filipa Lacerda @filipa 7 years ago

Contributor

Tested locally and LGTM, thanks @iamphill
Filipa Lacerda merged 7 years ago

merged
Filipa Lacerda mentioned in commit 8e606369 7 years ago

mentioned in commit 8e606369
Jose Ivan Vargas @jivanvl 7 years ago

Developer

Picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14002, will merge into 9-5-stable ready for 9.5.3
Filipa Lacerda mentioned in commit 719c925e 7 years ago

mentioned in commit 719c925e
Clement Ho mentioned in issue #37589 (closed) 7 years ago

mentioned in issue #37589 (closed)

Please register or sign in to reply