Calculate top position with flash message after the request is received
What does this MR do?
Takes in consideration the flash alert message, which is already done in master. Moves the function to verify the top position after the ajax request has finished. - needs to be ported to master.
Screenshots (if relevant)
![]() |
![]() |
Does this MR meet the acceptance criteria?
- Tests
-
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #34461 (closed)
/cc @ClemMakesApps @kushalpandya this needs to go in the next patch
Merge request reports
Activity
mentioned in merge request !12559 (merged)
@mikegreiling and @jamedjo, I realize 9.3.3 is almost ready for tagging. Letting you both decide whether to add this to 9.3.3 or 9.3.4
karma job keeps failing in here with:
[PhantomJS 2.1.1 (Linux 0.0.0)]: Disconnected (1 times), because no message in 10000 ms. PhantomJS 2.1.1 (Linux 0.0.0) ERROR Disconnected, because no message in 10000 ms. PhantomJS 2.1.1 (Linux 0.0.0) ERROR Disconnected, because no message in 10000 ms.
Does it have to do with the phantomjs change?
@iamphill can you please review in the meanwhile? Thanks!
assigned to @iamphill
It's transient.. I haven't seen it with Chrome so far.
Also just a heads up. Let @mikegreiling or @jamedjo be the one to merge this.
9-3-stable
and9-3-stable-ee
are almost ready for tagging. If this gets merged without RM notice, we could end up with something in9-3-stable
and not9-3-stable-ee
because there wasn't a CE => EE.@ClemMakesApps this is a customer report. If it is a transient failure maybe we can merge it as is
@iamphill what do you think? cc @mikegreiling and @jamedjo
enabled an automatic merge when the pipeline for 54b86434 succeeds
Tried the karma failure one more time. @jamedjo this should be merged soon.
mentioned in commit 4d59b8c6
mentioned in issue #34461 (closed)