Sign in or sign up before continuing. Don't have an account yet? Register now to get started.
Register now

Reword (or fix) "Force domains with SSL certificates to use HTTPS"

Summary

On the Pages project admin page the "Force domains with SSL certificates to use HTTPS" checkbox value is poorly worded (or there is a bug). A normal user would understand that this checkbox will still allow them to add a domain without an SSL certificate. However, at least on gitlab.com, this setting stops the user from adding a domain without a certificate with the message "Certificate must be present if HTTPS-only is enabled\n\nKey must be present if HTTPS-only is enabled".

Steps to reproduce

Create a new project. Attempt to add a domain without a certificate when the checkbox is checked.

Example Project

https://gitlab.com/transcrobes/charts/pages

What is the current bug behavior?

Can't add a domain without an SSL cert when the checkbox "Force domains with SSL certificates to use HTTPS"

What is the expected correct behavior?

Either the checkbox should read "HTTPS-only" or "HTTPS-only and redirect http to https" or a user should be able to add a domain without a certificate and only redirect for domains that have SSL certs.

Relevant logs and/or screenshots

Certificate must be present if HTTPS-only is enabled\n\nKey must be present if HTTPS-only is enabled

Output of checks

This bug happens on GitLab.com

Possible fixes

https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/views/projects/pages/_https_only.html.haml#L6

This is not the same issue as: https://gitlab.com/gitlab-org/gitlab-ce/issues/55315 https://gitlab.com/gitlab-org/gitlab-ce/issues/45569

or even:

https://gitlab.com/gitlab-org/gitlab-ce/issues/45102 https://gitlab.com/gitlab-org/gitlab-ce/issues/55357

which are quite closely related.

Assignee Loading
Time tracking Loading