Pages > Domains: Force https form confusing

Description

If you have no https pages, the "Force domains with SSL certificates to use HTTPS" form is confusing, because the checkbox is disabled and you have no save button. The explanation why this is disabled is hidden behind the title attribute of the checkbox label:

without-https

With https:

with-https

The form feels out of place anyway.

Proposal

  • Either use a tooltip or better a help text below the checkbox.
  • Maybe this setting should live in a separate "Settings" box below or above the domains.
  • The save button should be disabled and not disappear

Links / references

Maybe this should be added to the Issue https://gitlab.com/gitlab-org/gitlab-ce/issues/38481 instead of being a separate one.

Edited by Lukas Eipert