@csoriano: Can you please verify the requirements in the description above. Note that in our current implementation, rebase is one button click, and then merge is a separate button click.
Also I've specified in the description that we are not bringing squash and merge to CE. That's another feature that's related. But we currently have no plans to do so. Please let us know this makes sense for GNOME.
Can you please verify the requirements in the description above.
They look good.
Note that in our current implementation, rebase is one button click, and then merge is a separate button click.
That's perfectly fine :).
Sounds like an interesting idea to have a "rebase + merge" similar to the "merge after CI passes", but it's a non-important detail. I can file a feature request for that for discussion if that sounds interesting.
Also I've specified in the description that we are not bringing squash and merge to CE. That's another feature that's related. But we currently have no plans to do so. Please let us know this makes sense for GNOME.
@victorwu looks good. Noting what was stated elsewhere, this should not be merged before we get the official decision from GNOME that they will migrate to GitLab.
Sounds like an interesting idea to have a "rebase + merge" similar to the "merge after CI passes", but it's a non-important detail. I can file a feature request for that for discussion if that sounds interesting.
@smcgivern thanks! The discussion/description is longer than I expected so I didn't read it all :)
In summarize seems to be the two buttons merged into one to not wait for the rebase & CI (I didn't think about the CI part since we are still figuring out the CI stuff, it's a good point) and seems to be in the plans already, so looks good!
Thanks for confirming @eliran.mesika . To be clear, once we get the go ahead from yourself, then we will add a specific milestone to this issue here, and schedule it for that milestone to be worked on and merged in that specific milestone.
Thanks @csoriano for verifying the description and scope of this work.