17.9 Backport: jliu/gitaly-dns-tls
grpc: Enable dns lookup by default with NewClient
See merge request !7673 (merged)
Merge request reports
Activity
assigned to @jcaigitlab
added groupgitaly label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer None @mustafabayar
(UTC+1, 5 hours ahead of author)
@echui-gitlab
(UTC+11, 15 hours ahead of author)
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerEdited by ****added 7 commits
- 758396ca - grpc: Remove FailOnNonTempDialError options
- 14b7fd3c - grpc: Enable dns lookup by default with NewClient
- 409fe3f9 - grpc: Rename client.Dial to client.New
- d5980426 - grpc: Remove grpc.WithBlock
- bbca45df - test: Limit package concurrency to 4
- 3735b6cd - test: Enable the --rerun-fails flag
- e185cc88 - test: Quarantine Praefect flaky tests on MacOS
Toggle commit list- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
👋 @jcaigitlab
- please see the following guidance and update this merge request.1 Error ❌ Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added typefeature label
changed milestone to %17.10
requested review from @jamesliu-gitlab
mentioned in issue #6674
started a merge train
removed this merge request from the merge train because the pipeline did not succeed. Learn more.
started a merge train
removed this merge request from the merge train because the pipeline did not succeed. Learn more.
started a merge train
removed this merge request from the merge train because the pipeline did not succeed. Learn more.
started a merge train