Skip to content

Bump Gitaly's clients gitalyclient dependency versions to include dns lookup changes

Gitaly currently uses the deprecated grpc.DialContext, which requires dns: prefixes for DNS resolution. However, tls: addresses lose DNS resolution because the dns: prefix is stripped. This creates issues when connecting to hostnames over TLS.

The new grpc.NewClient solves this by enabling DNS resolution by default, even without dns: prefixes. For example, tls://mygitalynode.test:1234 will now correctly resolve DNS. Only addresses with a DNS authority still require dns:.

MR !7673 (merged) replaces grpc.DialContext with grpc.NewClient to simplify connection handling and fix the DNS resolution issue. Since Gitaly wraps gRPC connection logic, the change only needs to be made in one place. (More details in the MR's description)

Backport MRs on Gitaly:

Once it is merged, the clients of Gitaly need to update its dependencies to include this changes. New version is not-created-yet.

This issue is used to track MRs/Issues for each client:

Edited by Eric Ju
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information