Bump Gitaly's clients gitalyclient dependency versions to include dns lookup changes
Gitaly currently uses the deprecated grpc.DialContext, which requires dns: prefixes for DNS resolution. However, tls: addresses lose DNS resolution because the dns: prefix is stripped. This creates issues when connecting to hostnames over TLS.
The new grpc.NewClient solves this by enabling DNS resolution by default, even without dns: prefixes. For example, tls://mygitalynode.test:1234 will now correctly resolve DNS. Only addresses with a DNS authority still require dns:.
MR !7673 (merged) replaces grpc.DialContext with grpc.NewClient to simplify connection handling and fix the DNS resolution issue. Since Gitaly wraps gRPC connection logic, the change only needs to be made in one place. (More details in the MR's description)
Backport MRs on Gitaly:
- 17.7 Backport: !7703 (merged)
- 17.8 Backport: jliu/gitaly-dns-tls: !7693 (merged)
- 17.9 Backport: jliu/gitaly-dns-tls: !7692 (merged)
Once it is merged, the clients of
Gitaly need to update its dependencies to include this changes. New version is not-created-yet.
This issue is used to track MRs/Issues for each client:
-
GitLab Rails application, see Gemfilesee #6674 (comment 2394263721) -
GitLab Shell, see go.mod
- gitlab-shell!1251 (merged)
- No backport is needed.
-
GitLab Workhorse, see go.mod
- gitlab!184525 (merged)
- backports: backport request issue is at https://gitlab.com/gitlab-org/release/tasks/-/issues/18103.
- 17.7: gitlab!185018 (closed)
- 17.8: gitlab!184643 (merged)
- 17.9: gitlab!184639 (merged)
-
GitLab Elasticsearch Indexer, see go.mod
- gitlab-elasticsearch-indexer!584 (merged)
- backport:
- According to Global search team's suggestion, I will "open backport MRs in the gitlab-org/gitlab project to the stable branches to use version 5.5.0"
- gitlab!184942 (merged) puts 5.5.0 into Gitlab Master
- gitlab!184989 (closed) puts 5.5.0 into Gitlab 17.9
- gitlab!185127 (closed) puts 5.5.0 into Gitlab 17.8
-
GitLab Zoekt Indexer, see go.mod
- gitlab-zoekt-indexer!390 (merged)
- backport: No backport is needed according to Global search team's suggestion