An error occurred while fetching this tab.
praefect: Handle replica paths in 'track-repository' and 'track-repositories' subcommands
- Aug 22, 2023
-
-
Will Chandler (ex-GitLab) authored
In the previous commit we updated the `track-repository` subcommand to differentiate between replica paths and relative paths. We now do the same for the `track-repositories` subcommand. Changelog: fixed
-
Will Chandler (ex-GitLab) authored
The `track-repository` subcommand has assumed that the relative path and replica path of a repository are the same. However, since v15.0 this is no longer the case and the command has been unable to handle paths that use the `@cluster` format. To resolve this, differentiate between relative paths, those used by clients (e.g. rails), and replica paths used internally by Praefect and require both to be passed by users. We temporarily manually set replica path to match relative path in `track-repositories` to keep tests passing. In the following commit this will be updated to use the deserialized value from the user.
-
Will Chandler (ex-GitLab) authored
Historically the Praefect tracking subcommands have not distinguished between the relative path[0] used by clients and the replica path used internally by Praefect[1]. Now that replica paths are in common usage we need to make it clear which path the user is specifying. In preparation for adding a new flag for replica paths, rename the `-repository` flag to `-relative-path`, which matches the names used in our documentation. [0] https://docs.gitlab.com/ee/administration/gitaly/#client-generated-replica-paths [1] https://docs.gitlab.com/ee/administration/gitaly/#praefect-generated-replica-paths-gitlab-150-and-later
-
Will Chandler (ex-GitLab) authored
Currently the `TestTrackRepositoriesSubcommand` test will validate that the expected error message is displayed, but does not check the more detailed information on what specifically was wrong with the input. Expand the test cases to assert the full output of the commands.
-