Skip to content
Snippets Groups Projects

praefect: Handle replica paths in 'track-repository' and 'track-repositories' subcommands

Merged Will Chandler (ex-GitLab) requested to merge wc/track-repo-replica-path into master
All threads resolved!

Historically the Praefect tracking subcommands have not distinguished between the relative path used by clients and the replica path used internally by Praefect. Now that replica paths are in common usage we need to make it clear which path the user is specifying.

Rename the -repository flag to -relative-path, which matches the names used in our documentation, and then update the track-repository and track-repositories subcommands to use it.

Closes #5402 (closed)

Edited by Will Chandler (ex-GitLab)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Evan Read removed review request for @eread

    removed review request for @eread

  • Patrick Steinhardt
  • Patrick Steinhardt
  • Patrick Steinhardt
  • added 45 commits

    • 9cddeb02...23c88f21 - 41 commits from branch master
    • f05c9a2b - praefect: Assert more track-repositories output
    • 02c2260a - praefect: Rename 'repository' to 'relative-path'
    • 6efd1c0c - praefect: Use replica paths in track-repository
    • bfbb8f66 - praefect: Use replica paths in track-repositories

    Compare with previous version

  • requested review from @eread

  • Patrick Steinhardt approved this merge request

    approved this merge request

  • Patrick Steinhardt removed review request for @pks-gitlab

    removed review request for @pks-gitlab

  • Justin Tobler approved this merge request

    approved this merge request

  • Evan Read approved this merge request

    approved this merge request

  • Evan Read removed review request for @eread

    removed review request for @eread

  • Patrick Steinhardt started a merge train

    started a merge train

  • Patrick Steinhardt removed this merge request from the merge train because pipeline did not succeed. Learn more.

    removed this merge request from the merge train because pipeline did not succeed. Learn more.

  • Patrick Steinhardt enabled automatic add to merge train when the pipeline for deae0a49 succeeds

    enabled automatic add to merge train when the pipeline for deae0a49 succeeds

  • Patrick Steinhardt started a merge train

    started a merge train

  • mentioned in commit 5649e8da

  • added workflowstaging label and removed workflowcanary label

  • mentioned in commit gitlab@89843fbe

  • mentioned in merge request gitlab!130356 (merged)

  • resolved all threads

  • Will Chandler (ex-GitLab) picked the changes into the branch cherry-pick-5649e8da with commit 23bf5ded

    picked the changes into the branch cherry-pick-5649e8da with commit 23bf5ded

  • mentioned in commit 23bf5ded

  • mentioned in merge request !6337 (merged)

  • Will Chandler (ex-GitLab) picked the changes into the branch cherry-pick-5649e8da-2 with commit bb26f95a

    picked the changes into the branch cherry-pick-5649e8da-2 with commit bb26f95a

  • mentioned in commit bb26f95a

  • mentioned in merge request !6338 (merged)

  • Will Chandler (ex-GitLab) picked the changes into the branch cherry-pick-5649e8da-3 with commit d38a02d5

    picked the changes into the branch cherry-pick-5649e8da-3 with commit d38a02d5

  • mentioned in commit d38a02d5

  • mentioned in merge request !6339 (merged)

  • Justin Tobler mentioned in commit b2c071d0

    mentioned in commit b2c071d0

  • Justin Tobler mentioned in commit 3258eafd

    mentioned in commit 3258eafd

  • Justin Tobler mentioned in commit 7d259a61

    mentioned in commit 7d259a61

  • mentioned in issue #5529 (closed)

  • mentioned in merge request omnibus-gitlab!7681 (merged)

  • Please register or sign in to reply
    Loading