praefect: Handle replica paths in 'track-repository' and 'track-repositories' subcommands
Historically the Praefect tracking subcommands have not distinguished between the relative path used by clients and the replica path used internally by Praefect. Now that replica paths are in common usage we need to make it clear which path the user is specifying.
Rename the -repository
flag to -relative-path
, which matches the names used in our documentation, and then update the track-repository
and track-repositories
subcommands to use it.
Closes #5402 (closed)
Merge request reports
Activity
assigned to @wchandler
- A deleted user
added groupgitaly typebug labels
added devopssystems sectioncore platform labels
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer ~ Patrick Steinhardt (
@pks-gitlab
) (UTC+2, 6 hours ahead of@wchandler
)Quang-Minh Nguyen (
@qmnguyen0711
) (UTC+7, 11 hours ahead of@wchandler
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerchanged milestone to %16.4
added bugfunctional + 1 deleted label and removed devopssystems groupgitaly sectioncore platform labels
added devopssystems sectioncore platform labels
- A deleted user
added groupgitaly label
requested review from @pks-gitlab
requested review from @justintobler
requested review from @eread
- Resolved by Will Chandler (ex-GitLab)
- Resolved by Will Chandler (ex-GitLab)
- Resolved by Will Chandler (ex-GitLab)
- Resolved by Will Chandler (ex-GitLab)
- Resolved by Evan Read
Thanks for the ping @wchandler. Just a couple of suggestions from me!
I like the parameter rename, because this might be the only subcommand that was using
--repository
? That said, much bigger docs impact: https://docs.gitlab.com/ee/administration/gitaly/recovery.html#praefect-tracking-database-maintenance.Back with you!
added Technical Writing UI text labels
removed review request for @eread
- Resolved by Patrick Steinhardt
- Resolved by Will Chandler (ex-GitLab)
- Resolved by Will Chandler (ex-GitLab)
- Resolved by Will Chandler (ex-GitLab)
@wchandler Thanks! A question that I basically answered by myself, and one small correction.
- Resolved by Justin Tobler
@wchandler Nothing else to add. Being that this is a breaking change, do we expect it to significantly effect customers? Or since these commands were already broken for replica path, do it not really matter?
added 45 commits
-
9cddeb02...23c88f21 - 41 commits from branch
master
- f05c9a2b - praefect: Assert more track-repositories output
- 02c2260a - praefect: Rename 'repository' to 'relative-path'
- 6efd1c0c - praefect: Use replica paths in track-repository
- bfbb8f66 - praefect: Use replica paths in track-repositories
Toggle commit list-
9cddeb02...23c88f21 - 41 commits from branch
requested review from @eread
removed review request for @pks-gitlab
removed review request for @eread
removed this merge request from the merge train because pipeline did not succeed. Learn more.
enabled automatic add to merge train when the pipeline for deae0a49 succeeds
mentioned in commit 5649e8da
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in commit gitlab@89843fbe
mentioned in merge request gitlab!130356 (merged)
picked the changes into the branch
cherry-pick-5649e8da
with commit 23bf5dedmentioned in commit 23bf5ded
mentioned in merge request !6337 (merged)
picked the changes into the branch
cherry-pick-5649e8da-2
with commit bb26f95amentioned in commit bb26f95a
mentioned in merge request !6338 (merged)
picked the changes into the branch
cherry-pick-5649e8da-3
with commit d38a02d5mentioned in commit d38a02d5
mentioned in merge request !6339 (merged)
mentioned in commit b2c071d0
mentioned in commit 3258eafd
mentioned in commit 7d259a61
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue #5529 (closed)
mentioned in merge request omnibus-gitlab!7681 (merged)
mentioned in issue omnibus-gitlab#8691