Skip to content

Remove upload_pack_gitaly_hooks feature flag

Jacob Vosmaer requested to merge jv-pack-objects-feature-flag into master

This has the side effect that all calls to PostUploadPack and SSHUploadPack will invoke the PackObjectsHook RPC via gitaly-hooks.

Part of gitlab-com/gl-infra/scalability#921 (closed).

In !3264 (merged), we wrote:

We still keep the feature flag so if people want to use the cache they must enabled it in config.toml AND enable the feature flag.

We have now started writing documentation and we realized that this situation of having 2 toggles is confusing, and that the feature flag serves no purpose anymore. So this MR removes the feature flag.

The pack-objects cache itself remains off by default, because it needs to be explicitly enabled in config.toml.

Edited by Jacob Vosmaer

Merge request reports