Skip to content

Relax path validation in Go port of UserCommitFiles

Sami Hiltunen requested to merge smh-fix-user-commit-files into master

  • Path validation in the Go port of UserCommitFiles is stricter than it has to be and does not match the Ruby implementation's behavior. This commit removes the requirement that the path has to be clean but still keeps protections against path traversals.

  • The connection pool given to Gitaly's server factory constructor was not correctly passed forward. This sets the passed in parameter to the field.

Related to #3074 (closed)

Edited by Sami Hiltunen

Merge request reports