Skip to content

CGC-252 | Refactor and include SessionUserConcern in app/controllers/application_controller.rb

What does this MR do and why?

CGC-252 | Refactor and include SessionUserConcern in app/controllers/application_controller.rb

  • created SessionUser struct vs using a hash to store the session user
  • created a domain model for the SessionUser struct
  • updated access to use the struct attributes
  • included the SessionUser concern in ApplicationController due to wide usage in app and api controllers

References

#252 (closed)

Validation steps

@leetickett-gitlab - one area I had issues testing was the integration within some of the API endpoints, but that felt like a piece out of scope within a local development environment. If you can jot down any additional validation functional test cases I can do, go for it!

/cc @leetickett-gitlab

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading