Skip to content

Fix custom User-Agent header on S3 requests

João Pereira requested to merge fix-user-agent-s3 into master

This is a followup from #214 (comment 414508659).

The fix allows us to properly set the User-Agent header on S3 requests without needing to use the client/transport package:

2020/09/17 16:57:38 DEBUG: Request s3/ListObjectsV2 Details:
---[ REQUEST POST-SIGN ]-----------------------------
GET /populate?delimiter=%2F&list-type=2&max-keys=1000&prefix=docker%2Fregistry%2Fv2%2Frepositories%2F HTTP/1.1
Host: 127.0.0.1:9000
User-Agent: docker-distribution/v2.9.1-gitlab-431-g84ebaae0.m (go1.14.4) aws-sdk-go/1.27.0 (go1.14.4; darwin; amd64)
Authorization: AWS4-HMAC-SHA256 Credential=minioadmin/20200917/us-east-2/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=3c1792ebc7a6b524728b44fdcd5c9d8831ac907f8fafe4000889d8fb6cf976ff
X-Amz-Content-Sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
X-Amz-Date: 20200917T155738Z
Accept-Encoding: gzip

Related to #214 (closed).

Edited by João Pereira

Merge request reports