Investigate ConfigurationProject RPS errors
Grana query (basically what we have as our error budget SLI):
sum by (grpc_code,grpc_service) (
grpc_server_handled_total{app="kas",env="gprd",grpc_code!~"^(OK|NotFound|FailedPrecondition|Unauthenticated|PermissionDenied|Canceled|DeadlineExceeded|ResourceExhausted)$"}
)
See source code and Sentry for clues: https://sentry.gitlab.net/gitlab/kas/issues/3029700/?environment=gprd Gitaly is returning an error. Most likely something to do with default branch selection?
Proposal
-
Rework gitlab-org/gitlab!81950 (merged) to have the
default_branch
field one level up - as a sibling rather than nested withingitaly_repository
. Reasons:- To match what we did in the proto definition for the gRPC request here !606 (diffs)
- We use the type from Gitaly to parse JSON response in both agent info and project info structs. We don't want to modify it.
-
Pass the branch from rails to kas in the
ListAgentConfigFiles
API call. kas already supports that but rails doesn't do that. -
Rails returns default branch name for agent/project info. kas doesn't use that! It should.
Edited by Mikhail Mazurskiy