Skip to content

Remove explicit setting of service.enabled to allow the user to override in .auto-deploy-values

daghaian requested to merge daghaian/auto-deploy-image:remove-explicit-service-enabled-flag into master

This MR is in conjunction with an open MR in auto-deploy-app #56

The purpose of this MR is to remove the explicit setting of service.enabled. As it stands the only way a user can override the enabling of ingress/service is through HELM_ADDITIONAL_ARGS. Given that the default for service.enabled is already true in the chart, MR #56 (closed) appends to the conditional on service.yaml and ingress.yaml to check the value for application.track in conjunction with service.enabled to decide whether the resources should be included.

Merge request reports