Skip to content

Allow user to disable service/ingress

daghaian requested to merge daghaian/auto-deploy-app:allow-disabling-service-and-ingress into master

Currently, when the chart is used in conjunction with the latest version of Auto Devops, the user has no control over disabling service/ingress.

Looking at the auto-deploy-image the value of service.enabled is set explicitly as a flag to the helm upgrade command. As such, the only way a user can override this setting is by adding an additional --set service.enabled=false to the HELM_ADDITIONAL_ARGS. This MR proposes that the logic pertaining to whether or not service/ingress should be enabled is moved into the chart itself and be based on the combination of service.enabled and application.track. Given the default values for both these variables, if a user opts to use the chart agnostic of the auto-deploy-image, functionality will remain as it is currently.

A subsequent MR will be made for auto-deploy-image to remove the explicit setting of service.enabled assuming this is merged.

Edited by daghaian

Merge request reports