Skip review jobs if not on canonical
What does this MR do?
Skip review jobs if not on canonical
Skip review CI jobs not only on the dev mirror, but also on the renovate mirror, since canonical is the only GitLab Operator repository with review clusters.
If a renovate MR needs e2e/QA validation we can trigger a upstream (canonical) pipeline on demand.
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened -
Validate potential values for new configuration settings. Formats such as integer10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Test Plan
-
Confirm renovate pipelines skip review jobs: https://gitlab.com/gitlab-renovate-forks/gitlab-operator/-/pipelines/1475151856 -
Confirm canonical pipelines do not skip review jobs: https://gitlab.com/gitlab-org/cloud-native/gitlab-operator/-/pipelines/1475151859
Related issues
Closes #1711 (closed)
Edited by Clemens Beck