Revisit override and default values
What does this MR do?
Revisit override and default values
Move all RBAC related override values to default values to enable users to use custom service accounts.
Override values related to certmanager and GitLab runner are unchanged because the Operator does not manage these components. Values to set custom labels also remain overrides, since the Operator uses these labels to query resources.
Changelog: changed
Closes #1089 (closed)
Relates #1737
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened -
Validate potential values for new configuration settings. Formats such as integer10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Related issues
Closes #1089 (closed)
Merge request reports
Activity
changed milestone to %17.5
assigned to @clemensbeck
1 Message Please add the workflowready for review label once you think the MR is ready to for an initial review, and assign
a reviewer based on the Reviewer Roulette suggestion below.Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our First-response SLO.
If you don't receive a response, please mention
@gitlab-org/distribution
, or one of our Project MaintainersReviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer @balasankarc
(UTC+5.5, 3.5 hours ahead of author)
@WarheadsSE
(UTC-4, 6 hours behind author)
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermarked the checklist item When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow as completed
@balasankarc can you please review?
added workflowready for review label
requested review from @balasankarc
- Resolved by Jason Plum
Looks like it does what we want. Approving and passing on to @pursultani for merge.
requested review from @pursultani
requested review from @WarheadsSE and removed review request for @pursultani
mentioned in commit 12698f95
mentioned in issue #1737
mentioned in issue gitlab-org/gitlab-environment-toolkit#109 (closed)
mentioned in commit bc3c32fd
mentioned in merge request !1007 (merged)
mentioned in commit f5221fb6
mentioned in commit fc423e80
mentioned in issue #1784 (closed)