Skip to content
Snippets Groups Projects

Revisit override and default values

Merged Clemens Beck requested to merge 1089-overrides-to-default into master
All threads resolved!

What does this MR do?

Revisit override and default values

Move all RBAC related override values to default values to enable users to use custom service accounts.

Override values related to certmanager and GitLab runner are unchanged because the Operator does not manage these components. Values to set custom labels also remain overrides, since the Operator uses these labels to query resources.

Changelog: changed

Closes #1089 (closed)

Relates #1737

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

Related issues

Closes #1089 (closed)

Edited by Clemens Beck

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading