Skip to content

Fix golangci lint config

Lucas Li requested to merge fix-golangci-lint-config into master

What does this MR do?

Fixed golangci-linter configurations.

The whitespace linter was not properly configured.

Caught an issue with the corrected config:

$ golangci-lint run
controllers/gitlab/postgresql.go:89:4: multi-line statement should be followed by a newline (whitespace)
                        return s

Silenced it, because of a confliction with block should not start with a whitespace (wsl) 😓

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

Related issues

Edited by Lucas Li

Merge request reports