Skip to content

Feature: enable choice of images in values.yaml for kube-rbac-proxy

Falltrades requested to merge Falltrades/gitlab-operator:Feat-kube-rbac-proxy-image-arguments into master
  • Please check this box if this contribution uses AI-generated content as outlined in the GitLab DCO & CLA

What does this MR do?

This MR enable the possibility to specify values for gcr.io/kubebuilder/kube-rbac-proxy:v0.14.1 in the values.yaml. This is useful when we need to use private repository for instance.

Update 3 files

  • /deploy/chart/templates/manager/deployment.yaml
  • /deploy/chart/templates/_helpers.tpl
  • /deploy/chart/values.yaml

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

Related issues

Closes #1580 (closed)

Edited by João Alexandre Cunha

Merge request reports