Skip to content

Draft: Add and improve log entries

Mitchell Nielsen requested to merge critical-logs into master

What does this MR do?

Adds and improves log entries in the reconcile loop.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

Related issues

Closes #327 (closed)

References

Test plan

# Build the Operator manifest and install it.
TAG=critical-logs task build_operator
kubectl apply -f .build/operator.yaml

# Apply your CustomResource using the second or third CHART_VERSION so we can upgrade it later.
kubectl apply -f mygitlab.yaml

# Watch the logs and look for any issues/improvements in the logs.

# Update your CustomResource with the first or second CHART_VERSION so we can upgrade the instance.
kubectl apply -f mygitlab.yaml

# Again, watch the logs and look for any issues/improvements.
Edited by Mitchell Nielsen

Merge request reports