Skip to content

Trim the vcluster name to 52 characters

Clemens Beck requested to merge fix-vcluster-name into master

What does this MR do?

Trim the vcluster name to 52 characters:

  • Helm release names are limited to 53 characters.
  • The vcluster charts creates a StatefulSet with the release name:

The controller-revision-hash label consists of {statefulset name}-{controller hash}:

  1. A controller hash has up to 10 chars
  2. The StatefulSet name is the release name: https://github.com/loft-sh/vcluster/blob/v0.19.2/charts/k3s/templates/syncer.yaml#L5
  3. release/vcluster/statefulset name max length = 63 (label max length) - 10 (controller hash) - 1 (hyphen) = 52

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

Related issues

Edited by Clemens Beck

Merge request reports