Skip to content

Update codeowners for docs tooling

Marcel Amirault requested to merge update-codeowners-marcel into master

What does this MR do?

As we noticed in !729 (comment 1722607406), seems my username got dropped from the docs tooling entries when adding the codeowners for this project in !677 (merged).

As per the description of gitlab-org/charts/gitlab!3313 (merged), this should have been based on https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/CODEOWNERS, where you can see my username is there. This also matches the codeowners for omnibus-gitlab: https://gitlab.com/gitlab-org/omnibus-gitlab/-/blob/master/.gitlab/CODEOWNERS?ref_type=heads#L22-26

.markdownlint.yml @marcel.amirault @eread @aqualls @gitlab-org/tw-leadership
/doc/.markdownlint/ @marcel.amirault @eread @aqualls @gitlab-org/tw-leadership
/doc/.vale/ @marcel.amirault @eread @aqualls @gitlab-org/tw-leadership

I've also added the missing entry for /doc/.markdownlint/, which should have the same codeowners.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

Related issues

Edited by Mitchell Nielsen

Merge request reports