Skip to content

Fix modified chart catalog after a chart was rendered

Clemens Beck requested to merge fix-changed-chart-catalog into master

What does this MR do?

Fix modified chart catalog after a chart was rendered

When a chart is rendered, its `.Metadata.Dependencies` is modified,
which caused unexpected results when rendering the chart more than
once.

Fixed by deep copying the metadata value.

Changelog: fixed

Split-off from !690 (merged)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

Related issues

Edited by Mitchell Nielsen

Merge request reports