Loading
Reconcile every KAS Service from the chart
What does this MR do?
Reconcile every KAS Service from the chart
The KAS reconciler now creates or patches every Service the chart renders for KAS, instead of only the first one found by component. This prepares for the dedicated -kas-grpc Service that the chart adds for the KAS gRPC Ingress with Traefik.
Charts counterpart: Support KAS gRPC Ingress with Traefik (gitlab-org/charts/gitlab!5448 - merged)
Relate KAS gRPC Ingress: render and test default annot... (gitlab-org/charts/gitlab#6659 - closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
- Merge Request Title and Description are up to date, accurate, and descriptive
- MR targeting the appropriate branch
- MR has a green pipeline on GitLab.com
- When ready for review, MR is marked as ready (not a draft) and assigned to a reviewer.
Expected (please provide an explanation if not completing)
- Test plan indicating conditions for success has been posted and passes
- Documentation created/updated
- Tests added
- Integration tests added to GitLab QA
- Equivalent MR/issue for omnibus-gitlab opened
- Validate potential values for new configuration settings. Formats such as integer
10, duration10s, URIscheme://user:passwd@host:portmay require quotation or other special handling when rendered in a template and written to a configuration file.
Reviewers checklist
- As soon as you begin reviewing, select Start a review on your first comment so the MR shows Reviewer started review.
Related issues
Edited by Clemens Beck