Loading
Prefer chart-rendered BBMs wait Job, keep inline fallback
What does this MR do?
Prefer chart-rendered batched background migrations wait Job, keep inline fallback
During a zero-downtime upgrade the operator waited for batched background migrations by synthesizing a Job in Go (deep-copying the migrations Job and overwriting its args with an inline poll loop). This moves that logic out of the operator: it now prefers the wait Job the chart renders, and only falls back to the inline derivation for charts that predate it.
- Selects the chart Job by the
gitlab.com/batched-background-migrations-checklabel (partitioned out before the migrations Job, which sharesapp: migrations). - Enables
migrations.batchedBackgroundMigrationsCheckonly while upgrading. - Keeps the inline poll-loop derivation as a fallback.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
Implements #2223
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
- Merge Request Title and Description are up to date, accurate, and descriptive
- MR targeting the appropriate branch
- MR has a green pipeline on GitLab.com
- When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow
Expected (please provide an explanation if not completing)
- Test plan indicating conditions for success has been posted and passes
- Documentation created/updated
- Tests added
- Integration tests added to GitLab QA
- Equivalent MR/issue for omnibus-gitlab opened
- Validate potential values for new configuration settings. Formats such as integer
10, duration10s, URIscheme://user:passwd@host:portmay require quotation or other special handling when rendered in a template and written to a configuration file.
Related issues
Edited by Stefan Bordei