Reconcile NGINX custom template
What does this MR do?
Reconcile NGINX custom template
Reconcile custom template introduced in gitlab-org/charts/gitlab!4523.
Changelog: added
Relates: gitlab-org/charts/gitlab#2262
Test Plan
-
Build an Operator image which has gitlab-org/charts/gitlab!4523
FROM registry.gitlab.com/gitlab-org/cloud-native/gitlab-operator:cb-nginx-custom-tpl # Copy local build of https://gitlab.com/gitlab-org/charts/gitlab/-/merge_requests/4523 COPY gitlab-9.3.2.tgz /charts/
-
Load the image into your cluster or a registry
-
Deploy the Operator
-
Create a GitLab CR, matching the chart version you used in step 1
apiVersion: apps.gitlab.com/v1beta1 kind: GitLab metadata: name: gitlab spec: chart: values: certmanager-issuer: email: <redac> version: 9.3.2
-
Confirm the ConfigMap is created by the Operator and NGINX in healthy.
$ kubectl get cm -n gitlab-system | grep nginx-tpl gitlab-nginx-tpl 1 15s
-
NGINX Ingress behavior with the custom template is tested in gitlab-org/charts/gitlab!4523
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened -
Validate potential values for new configuration settings. Formats such as integer10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Related issues
Edited by Clemens Beck