Loading
Add gated batched background migrations wait Job to migrations chart
What does this MR do?
Add gated batched background migrations wait Job to migrations chart
Adds a wait Job to the migrations subchart that holds a zero-downtime upgrade until the current version's batched background migrations finish, so the operator no longer has to build that Job itself.
- New Job gated on
migrations.batchedBackgroundMigrationsCheck.enabled(default off), labelledgitlab.com/batched-background-migrations-checkand running/scripts/wait-for-batched-background-migrations. - Extracts the migrations Job's shared init/volume/volumeMount fragments into helpers so the two Jobs share config without duplication (rendered output of the existing migrations Job is unchanged).
Changelog: added
Implements gitlab-org/cloud-native/gitlab-operator#2223
Related issues
Author checklist
For general guidance, please follow our Contributing guide.
Required
For anything in this list which will not be completed, please provide a reason in the MR discussion.
- Merge Request Title and Description are up to date, accurate, and descriptive.
- MR targeting the appropriate branch.
- MR has a green pipeline.
- Documentation created/updated.
- Tests added/updated.
- Have you validated that your change works end-to-end on a real cluster deployment?
- Describe how you did it in a comment.
- Equivalent MR/issue for omnibus-gitlab opened.
- When ready for review, MR is marked as ready (not a draft) and assigned to a reviewer.
Reviewers checklist
- As soon as you begin reviewing, select Start a review on your first comment so the MR shows Reviewer started review.
- MR has a green pipeline on https://gitlab.com/gitlab-org/charts/gitlab.
- Consider downstream impact to the Operator, as per evaluating impact from changes to GitLab chart.
Edited by Stefan Bordei