Make webservice ClientTrafficPolicy specs overridable

Clemens Beckrequested to merge
cb/ctp-webservice-6571 into master

What does this MR do?

Make webservice ClientTrafficPolicy specs overridable

The section-scoped ClientTrafficPolicy (used by Envoy Gateway) resources the chart renders for the gitlab-web, gitlab-web-geo, and gitlab-smartcard-web listeners had their specs hardcoded in the templates.

As the section-scoped policies take precedence over the gateway-wide gatewayApiResources.envoy.clientTrafficPolicySpec, users could not customize ClientTrafficPolicy behavior for webservice listeners.

The specs are not exposed via gitlab.webservice.clientTrafficPolicy.[main|smartcard|geo].spec, allowing to inject a custom policy configuration for each listener.

Changelog: added

Background

Older chart versions used a single ClientTrafficPolicy controlled through global settings. To make the charts more self-contained, we split this into one ClientTrafficPolicy managed in the root chart plus a per-listener policy managed in each relevant sub-chart, for cases that need additional overrides.

This silently broke the ability to override the policies for the Rails, Geo, and Smartcard listeners: when a listener has a section-scoped policy, Envoy ignores the gateway-wide policy for that listener.

Related issues

Closes gatewayApiResources.envoy.clientTrafficPolicySp... (#6571 - closed) • João Alexandre Cunha

Author checklist

For general guidance, please follow our Contributing guide.

Required

For anything in this list which will not be completed, please provide a reason in the MR discussion.

  • Merge Request Title and Description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • MR has a green pipeline.
  • Documentation created/updated.
  • Tests added/updated.
  • Have you validated that your change works end-to-end on a real cluster deployment?
    • Describe how you did it in a comment.
  • Equivalent MR/issue for omnibus-gitlab opened.

Reviewers checklist

Edited by Lucas Li

Merge request reports