Fix dependencyProxy bucket validation when disabled
What does this MR do?
This MR fixes an issue in the gitlab-migrations job where it aborts during gitlab:db:configure with the error "Object storage for dependency_proxy must have a bucket specified" when dependencyProxy.enabled: false and consolidated object storage is enabled.
It accomplishes this by adding the missing gitlab.appConfig.dependencyProxy.configuration render call to the migrations/templates/configmap.yaml file.
Why was this MR needed? When consolidated object storage is enabled, it automatically assumes object storage configuration for all components, including dependencyProxy. However, if a user explicitly wants to override this behavior and disable dependencyProxy via dependencyProxy.enabled: false, the override was not being respected for the migrations job.
This occurred because the dependencyProxy.configuration template include was completely missing from the migrations configmap.yaml. Adding this missing line ensures the override settings are properly rendered and passed down to Rails, preventing it from failing the strict bucket validation checks when the proxy feature is intentionally disabled.
%{first_multiline_commit}
Related issues
Resolves #6423 (closed)
Author checklist
For general guidance, please follow our Contributing guide.
Required
For anything in this list which will not be completed, please provide a reason in the MR discussion.
- Merge Request Title and Description are up to date, accurate, and descriptive.
- MR targeting the appropriate branch.
- MR has a green pipeline.
- Documentation created/updated.
- Tests added/updated, and test plan for scenarios not covered by automated tests.
- Equivalent MR/issue for omnibus-gitlab opened.
Notes on unchecked items:
- Documentation: Not applicable. This is a backend template bug fix that doesn't change user-facing behavior or configuration schemas.
- Tests: No new tests were added because the existing RSpec template tests implicitly cover the configmap rendering.
- Omnibus: Not applicable. This is a Helm-chart specific template rendering bug.
Reviewers checklist
- MR has a green pipeline on https://gitlab.com/gitlab-org/charts/gitlab.
- Consider downstream impact to the Operator, as per evaluating impact from changes to GitLab chart.