Add global.openbao.psql config and deprecate openbao.psql

Dmytro Biryukovrequested to merge
dbiryukov_change_openbao_to_use_own_db_mr-590085 into master

What does this MR do?

Exposes OpenBao database configuration at the GitLab chart level via global.openbao.psql and fixes database precedence so connection.database overrides global.openbao.psql.database when both are set.

Closes #590085

Changes

1. Template changes (templates/_openbao.tpl)

openbao.postgresql.configuration:

  • Merges connection from global.psql → global.openbao.psql → connection
  • Database precedence: connection.database > global.openbao.psql.database > "openbao"
  • Ensures connection.database wins when both connection and global.openbao.psql are set

2. Removed openbao.psql

  • Dropped the openbao.psql subchart-level config; use global.openbao.psql or connection instead
  • templates/_removals.tpl: Blocks upgrade if openbao.psql is still configured

3. Defaults (values.yaml)

  • global.openbao.psql.database: openbao so toolbox and other consumers get the default database name
  • connection.database: '' so global.openbao.psql.database applies when not overridden

4. Config check (templates/_checkConfig_openbao.tpl)

  • Unchanged: still requires database config when OpenBao is enabled with external PostgreSQL

5. Documentation (doc/charts/openbao/_index.md)

  • Updated global.openbao.psql default and database precedence
  • Clarified that connection.database overrides global.openbao.psql.database

6. Tests (spec/configuration/openbao_spec.rb)

  • Precedence: connection.database overrides global.openbao.psql.database
  • Custom database via global.openbao.psql.database

Author checklist

For general guidance, please follow our Contributing guide.

Required

For anything in this list which will not be completed, please provide a reason in the MR discussion.

  • Merge Request Title and Description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • MR has a green pipeline.
  • Documentation created/updated.
  • Tests added/updated, and test plan for scenarios not covered by automated tests.
  • Equivalent MR/issue for omnibus-gitlab opened.

Reviewers checklist

Edited by Fabien Catteau

Merge request reports