Use shared gravatar config for all Rails gitlab.yml.erb configmaps
What does this MR do?
Adds a shared gitlab.appConfig.gravatar helper template to ensure global.appConfig.gravatar settings are consistently applied to all Rails pods' gitlab.yml.erb configmaps.
Changes:
- Creates
templates/_gitlab_appConfig_gravatar.tplhelper that rendersgravatar.plain_urlandgravatar.ssl_urlfromglobal.appConfig.gravatar - Replaces inline gravatar configuration in webservice, sidekiq, and geo-logcursor with the shared helper
- Adds gravatar configuration to toolbox and migrations (previously missing)
This ensures parity across all Rails components (webservice, sidekiq, geo-logcursor, toolbox, migrations) as requested in the issue.
Related issues
Closes #6067
Author checklist
For general guidance, please follow our Contributing guide.
Required
For anything in this list which will not be completed, please provide a reason in the MR discussion.
-
Merge Request Title and Description are up to date, accurate, and descriptive.
-
MR targeting the appropriate branch.
-
MR has a green pipeline.
- Will be verified after push and pipeline runs
-
Documentation created/updated.
- No documentation changes required. This MR ensures existing gravatar configuration (documented at https://docs.gitlab.com/charts/charts/globals#gravatarlibravatar-settings) is applied uniformly to all Rails pods without changing documented behavior.
-
Tests added/updated, and test plan for scenarios not covered by automated tests.
-
Manual testing performed:
helm dependency build .
helm template test .
-f values.yaml
--set certmanager-issuer.email=test@example.com
--set global.appConfig.gravatar.plainUrl=http://example.com
--set global.appConfig.gravatar.sslUrl=https://example.com \rendered.yaml - Verified
gravatar.plain_urlandgravatar.ssl_urlare present ingitlab.yml.erbfor:ConfigMap/test-webserviceConfigMap/test-sidekiqConfigMap/test-geo-logcursorConfigMap/test-toolboxConfigMap/test-migrations
-
Test plan: Automated tests should verify that all Rails configmaps include gravatar configuration when
global.appConfig.gravataris set.
-
Manual testing performed:
helm dependency build .
helm template test .
-
Equivalent MR/issue for omnibus-gitlab opened.
- Not applicable. This MR only affects Helm charts'
gitlab.yml.erbtemplate generation, not omnibus-gitlab templates.
- Not applicable. This MR only affects Helm charts'
Reviewers checklist
-
MR has a green pipeline on https://gitlab.com/gitlab-org/charts/gitlab.
-
Consider downstream impact to the Operator, as per evaluating impact from changes to GitLab chart.
- No breaking changes. This MR only adds missing gravatar configuration to toolbox and migrations, and consolidates existing configuration into a shared helper. All Rails pods now receive the same gravatar settings from
global.appConfig.gravatar.
- No breaking changes. This MR only adds missing gravatar configuration to toolbox and migrations, and consolidates existing configuration into a shared helper. All Rails pods now receive the same gravatar settings from