Change the default Registry database setting to prefer mode

Lucas Lirequested to merge
lli-registry-prefer-default into lli-registry-prefer

What does this MR do?

Change the default Registry database setting to prefer mode

Based on Add database prefer mode (!4671) They are the boring alternative to Add support for container registry detabase pre... (!4635)

With the default prefer mode:

  • For bundled PostgreSQL users, we run registry migrations
  • For external PostgreSQL users, we reject the settings just like: !4671
    • We will ask the user to set an explicit setting for registry.database.enabled

I believe this small breaking change could be a good opportunity to drive the adoption rate of Registry database.

If user don't want to migrate, or they just want to upgrade quickly, it only takes 1 min to read the message and set registry.database.enabled to false to dismiss the error.

Test plan

  1. With default values, it should deploy bundled PG and registry db in prefer mode
  2. With --set postgresql.install=false, it should reject the default settings.

Related issues

Author checklist

For general guidance, please follow our Contributing guide.

Required

For anything in this list which will not be completed, please provide a reason in the MR discussion.

  • Merge Request Title and Description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • MR has a green pipeline.
  • Documentation created/updated.
  • Tests added/updated, and test plan for scenarios not covered by automated tests.
  • Equivalent MR/issue for omnibus-gitlab opened.

Reviewers checklist

Edited by Lucas Li

Merge request reports